[google-guice] bslesinsky commented on revision r714.
Details are at http://code.google.com/p/google-guice/source/detail?r=714
Score: Positive
Line-by-line comments:
File:
/trunk/extensions/assistedinject/src/com/google/inject/assistedinject/Factories.java
(r714)
===============================================================================
Line 57: private static final Class[] ONLY_RIH = {
RealInvocationHandler.class };
-------------------------------------------------------------------------------
This could be RealInvocationHandler.IN_ARRAY
Line 59: static final Assisted DEFAULT_ASSISTED = new Assisted() {
-------------------------------------------------------------------------------
perhaps call this DEFAULT_ANNOTATION
Line 116: * }</pre>
-------------------------------------------------------------------------------
Should explain here that providers, provider methods, and deep injection
are supported.
Respond to these comments at
http://code.google.com/p/google-guice/source/detail?r=714
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
