[google-guice] limpbizkit commented on revision r714. Details are at http://code.google.com/p/google-guice/source/detail?r=714
Score: Neutral General Comment: bslesinsky: > -1 for not documenting how assisted inject works with other Guice features to supposedly make things "simpler". Bah humbug. Simpler is the wrong word. I should have said 'discouraged'. Injecting an @Assisted Provider<Foo> doesn't make sense. The returned value is a constant so the provider serves no purpose. I don't see the value in documenting that you can do this, since I don't think you should. Deep injection is something that I could also document, but I do not encourage it. The problem with deep injection is that it separates the @Assisted value from the constructed object. This leads to fragile code, so I don't really want to suggest users do this in the docs. So if I mention these features, I'd phrase it, "as a consequence of our implementation, you can do X, but you probably shouldn't." What should the documentation say? Respond to these comments at http://code.google.com/p/google-guice/source/detail?r=714 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/google-guice-dev?hl=en -~----------~----~----~----~------~----~------~--~---
