[google-guice] [EMAIL PROTECTED] commented on revision r723.
Details are at http://code.google.com/p/google-guice/source/detail?r=723
Score: Positive
General Comment:
(Further intra-company IDE snarking omitted)
Line-by-line comments:
File:
/trunk/extensions/assistedinject/test/com/google/inject/assistedinject/FactoryProvider2Test.java
(r723)
===============================================================================
Line 305: @SuppressWarnings("unused")
-------------------------------------------------------------------------------
> My IDE warns unless variables are both read and written to.
Fair enough, though I'll note that:
1) you just added code that does in fact read Prius.color, and
2) The two members on Fiat are being read in testFactoryWithImplicitBindings
I don't know why my Eclipse thought that Prius.color was already being read
before you added r730; that does seem a bug as bad as the IntelliJ bug of
thinking that the Fiat members are currently not being read.
Respond to these comments at
http://code.google.com/p/google-guice/source/detail?r=723
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
