Author: limpbizkit
Date: Sun Dec 28 22:19:04 2008
New Revision: 748

Removed:
    trunk/extensions/commands/
Modified:
    trunk/build.properties
    trunk/build.xml
    trunk/guice.ipr

Log:
Removing the obsolete commands extension. Almost all of it has been rolled  
into the Guice SPI.

The only remining file (InterceptingInjectorBuilder) now exists for  
maintenance on a new project that I set up for my personal use:
http://code.google.com/p/publicobject/
I'll have to copy this into Guiceberry which is currently the only project  
I know of that depends on this file.

My biggest problem with IIB is that it's a leaky abstraction. Unfortunately  
many bindings cannot be intercepted - anything that binds directly to a  
constructor is not eligible for interception. The approach taken by the  
guiceyfruit project (and potentially useful for inclusion in Guice proper)  
might be preferred. http://code.google.com/p/guiceyfruit/

Modified: trunk/build.properties
==============================================================================
--- trunk/build.properties      (original)
+++ trunk/build.properties      Sun Dec 28 22:19:04 2008
@@ -4,7 +4,6 @@
  servlet.src.dir=servlet/src
  spring.src.dir=spring/src
  assistedinject.src.dir=extensions/assistedinject/src
-commands.src.dir=extensions/commands/src
  throwingproviders.src.dir=extensions/throwingproviders/src
  multibindings.src.dir=extensions/multibindings/src
  privatemodules.src.dir=extensions/privatemodules/src

Modified: trunk/build.xml
==============================================================================
--- trunk/build.xml     (original)
+++ trunk/build.xml     Sun Dec 28 22:19:04 2008
@@ -28,7 +28,6 @@
      <ant antfile="extensions/assistedinject/build.xml" target="distjars"  
inheritAll="false"/>
      <ant antfile="extensions/throwingproviders/build.xml"  
target="distjars" inheritAll="false"/>
      <ant antfile="extensions/multibindings/build.xml" target="distjars"  
inheritAll="false"/>
-    <ant antfile="extensions/commands/build.xml" target="distjars"  
inheritAll="false"/>

      <copy toDir="${build.dir}/dist">
        <fileset dir="servlet/build" includes="*.jar"  
excludes="*-with-deps.jar"/>
@@ -48,9 +47,6 @@
      <copy toDir="${build.dir}/dist">
        <fileset dir="extensions/multibindings/build" includes="*.jar"  
excludes="*-with-deps.jar"/>
      </copy>
-    <copy toDir="${build.dir}/dist">
-      <fileset dir="extensions/commands/build" includes="*.jar"  
excludes="*-with-deps.jar"/>
-    </copy>

      <copy toDir="${build.dir}/dist" file="COPYING"/>
      <copy toDir="${build.dir}/dist">
@@ -108,7 +104,6 @@
          <pathelement location="${assistedinject.src.dir}"/>
          <pathelement location="${throwingproviders.src.dir}"/>
          <pathelement location="${multibindings.src.dir}"/>
-        <pathelement location="${commands.src.dir}"/>
        </sourcepath>
        <classpath refid="compile.classpath"/>
        <classpath>
@@ -129,7 +124,6 @@
      <ant dir="extensions/assistedinject" antfile="build.xml"  
target="clean"/>
      <ant dir="extensions/throwingproviders" antfile="build.xml"  
target="clean"/>
      <ant dir="extensions/multibindings" antfile="build.xml"  
target="clean"/>
-    <ant dir="extensions/commands" antfile="build.xml" target="clean"/>
    </target>

  </project>

Modified: trunk/guice.ipr
==============================================================================
--- trunk/guice.ipr     (original)
+++ trunk/guice.ipr     Sun Dec 28 22:19:04 2008
@@ -516,7 +516,6 @@
    <component name="ProjectModuleManager">
      <modules>
        <module  
fileurl="file://$PROJECT_DIR$/extensions/assistedinject/assistedinject.iml"  
filepath="$PROJECT_DIR$/extensions/assistedinject/assistedinject.iml" />
-      <module  
fileurl="file://$PROJECT_DIR$/extensions/commands/commands.iml"  
filepath="$PROJECT_DIR$/extensions/commands/commands.iml" />
        <module fileurl="file://$PROJECT_DIR$/guice.iml"  
filepath="$PROJECT_DIR$/guice.iml" />
        <module  
fileurl="file://$PROJECT_DIR$/extensions/multibindings/multibindings.iml"  
filepath="$PROJECT_DIR$/extensions/multibindings/multibindings.iml" />
        <module fileurl="file://$PROJECT_DIR$/servlet/servlet.iml"  
filepath="$PROJECT_DIR$/servlet/servlet.iml" />

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"google-guice-dev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/google-guice-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to