Count me in the column of users that care about startup time! Sam
On Sun, Jan 4, 2009 at 5:51 PM, Dhanji R. Prasanna <[email protected]> wrote: > > On Mon, Jan 5, 2009 at 5:27 AM, [email protected] <[email protected]> wrote: >> >> But there is an obvious improvement — we already have an API that >> builds and exposes the multimap! It's foolish that the Multibinder >> code doesn't use it. If you'd like, please change Multibinder to call >> this API: >> http://google-guice.googlecode.com/svn/trunk/latest-javadoc/com/google/inject/Injector.html#findBindingsByType(com.google.inject.TypeLiteral) > > Cool! I'll make this change. > >> >> On Optimization >> >> I'd want to optimize Guice, but I'd prefer a tool-driven approach. I >> suspect there will be a few places where changing an eagerly- >> initialized List into a Lazily-initialized one will have a measurable >> impact on performance. We should also set specific performance goals >> and decide what needs to be fast when there are tradeoffs. I think >> making the main injection loop fast is way more important than making >> injector-creation fast. > > I understand that the rush to optimize is perilous. However, I speak > from plenty of experience with Spring where exactly this kind of > linear injector scan has caused enormous slowdowns (their pointcut AOP > is a classic example). > > Whether users care about startup time or not... I think we should. =) > > Dhanji. > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/google-guice-dev?hl=en -~----------~----~----~----~------~----~------~--~---
