[google-guice] limpbizkit commented on branch /branches/1.0-maven. Details are at http://code.google.com/p/google-guice/source/branch?spec=issue313&branch=%2Fbranches%2F1.0-maven
Score: Positive General Comment: Thanks Greg! I'm not exactly sure what the guice-parent project does or if it's necessary, but I'm sure you'll explain! Line-by-line comments: File: /branches/1.0-maven/integration-parent/pom.xml (r806) =============================================================================== Line 6: <groupId>com.google.guice</groupId> ------------------------------------------------------------------------------- com.google.inject Line 14: <description>A collection of tools for integrating Guice with other libraries and frameworks</description> ------------------------------------------------------------------------------- shouldn't these be packaged independently? Spring folks and webwork folks probably don't overlap File: /branches/1.0-maven/pom.xml (r805) =============================================================================== Line 12: <groupId>junit</groupId> ------------------------------------------------------------------------------- curious - why does this go away? File: /branches/1.0-maven/pom.xml (r806) =============================================================================== Line 13: <!-- Google Collections and CGLib are not listed because they have been ------------------------------------------------------------------------------- Not tooo important here, but Guice 1.0 didn't dep on Google collections File: /branches/1.0-maven/servlet/pom.xml (r806) =============================================================================== Line 6: <groupId>com.google.guice.integration</groupId> ------------------------------------------------------------------------------- still think com.google.inject is better File: /branches/1.0-maven/spring/pom.xml (r806) =============================================================================== Line 5: <parent> ------------------------------------------------------------------------------- Aaah. . . . I'm learning Maven a bit here. The <parent> is another target that . .. owns this? Respond to these comments at http://code.google.com/p/google-guice/source/branch?spec=issue313&branch=%2Fbranches%2F1.0-maven -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/google-guice-dev?hl=en -~----------~----~----~----~------~----~------~--~---
