d...@happygiraffe.net commented on branch /branches/1.0-maven in project  
google-guice.
Details are at  
http://code.google.com/p/google-guice/source/branch?spec=issue313&branch=%2Fbranches%2F1.0-maven

Score: Positive

General Comment:
I've added some comments over on the issue page:  
http://code.google.com/p/google-guice/issues/detail?id=313&show=review&former=branchdetail#c2

Line-by-line comments:

File: /branches/1.0-maven/spring/pom.xml (r806)
===============================================================================

Line 5:   <parent>
-------------------------------------------------------------------------------
Parent is (roughly) a pom to pick up defaults from.  So you don't need to  
specify (e.g.) <version> as it's inherited from your parent.

(that's actually a bad example as you have to specify the version in the  
parent tag anyway)

Respond to these comments at  
http://code.google.com/p/google-guice/source/branch?spec=issue313&branch=%2Fbranches%2F1.0-maven
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"google-guice-dev" group.
To post to this group, send email to google-guice-dev@googlegroups.com
To unsubscribe from this group, send email to 
google-guice-dev+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/google-guice-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to