[email protected] commented on revision r995 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=995
Score: Positive
General Comment:
Thanks
Line-by-line comments:
File:
/trunk/servlet/src/com/google/inject/servlet/InternalServletModule.java
(r995)
===============================================================================
Line 39: @Provides @RequestScoped HttpServletRequest
provideHttpServletRequest() {
-------------------------------------------------------------------------------
We take a slight hit on performance since these objects must now be put in
/ got from the HttpServletRequest itself.
We can modify ServletScopes.REQUEST to optimize this..
Line 47: @Provides HttpSession provideHttpSession() {
-------------------------------------------------------------------------------
I wonder if the same change should be made to bind this in @SessionScoped.
Respond to these comments at
http://code.google.com/p/google-guice/source/detail?r=995
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
