Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 391 by mcculls: Scopes.SINGLETON does not detect re-entrant calls
http://code.google.com/p/google-guice/issues/detail?id=391

Original bug report: http://code.google.com/p/peaberry/issues/detail?id=35
Original diagnosis:
http://peaberry.googlecode.com/issues/attachment?aid=-5668176808220216508&name=bug.txt

Problem was tracked down to a circular dependency that isn't detected by
Guice, presumably because there's a provider involved in the circle? This
then had an interesting side-effect in the SINGLETON class where it made
two re-entrant calls.

The re-entrant call isn't detected by the SINGLETON code, so it silently
creates multiple instances. A flag could be added so it knows when it is
already processing a request - it could then report a circularity error.
But I'm not sure if this is worthwhile, or whether it is better to find out
why the original circularity was not detected.



--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"google-guice-dev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/google-guice-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to