limpbizkit commented on revision r1016 in project google-guice. Details are at http://code.google.com/p/google-guice/source/detail?r=1016
Score: Neutral General Comment: Thanks Greg. Some comments below... FYI, for future changes feel free to change trunk directly... Line-by-line comments: File: /branches/2.0-maven/guice-parent/pom.xml (r1016) =============================================================================== Line 8: <version>1</version> ------------------------------------------------------------------------------- curious? Do they version "parents" ? File: /branches/2.0-maven/servlet/pom.xml (r1016) =============================================================================== Line 12: <name>Google Guice - Integration: Servlet</name> ------------------------------------------------------------------------------- can you structure servlet, spring, etc. in the same way as assistedinject and grapher? I just haven't moved them to the extensions/ folder, but they're extensions just like grapher and assistedinject I don't see too much utility in having the 'extensions' project - can't everything directly parent under Guice? File: /branches/2.0-maven/spring/pom.xml (r1016) =============================================================================== Line 13: <description>Guice integration with the Spring container</description> ------------------------------------------------------------------------------- "the Spring container" --> "Spring" Line 23: <version>2.0.2</version> ------------------------------------------------------------------------------- Do we need to be this specific? File: /branches/2.0-maven/struts2/plugin/pom.xml (r1016) =============================================================================== Line 33: <version>2.0.5</version> ------------------------------------------------------------------------------- do we need to be this specific? Respond to these comments at http://code.google.com/p/google-guice/source/detail?r=1016 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/google-guice-dev?hl=en -~----------~----~----~----~------~----~------~--~---
