netdpb commented on revision r1034 in project google-guice. Details are at http://code.google.com/p/google-guice/source/detail?r=1034
Score: Positive General Comment: Looks good! I suppose the next step would be a MultisetBinder and a MultimapBinder? Line-by-line comments: File: /trunk/extensions/multibindings/src/com/google/inject/multibindings/Multibinder.java (r1034) =============================================================================== Line 334: * if only half of a multibinder user's remember to call permitDuplicates(), they're still ------------------------------------------------------------------------------- Did you mean "only half of a multibinder's users remember"? And would it be more precise to say that if *any one* user of an equivalent multibinder calls permitDuplicates, duplicates will be permitted in the bound set? Respond to these comments at http://code.google.com/p/google-guice/source/detail?r=1034 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/google-guice-dev?hl=en -~----------~----~----~----~------~----~------~--~---
