Comment #1 on issue 363 by dhanji: Optimize Injector Creation Performance http://code.google.com/p/google-guice/issues/detail?id=363
You've done an awesome job on this already. I would add one area where we can make a marginal improvement: Detect disjoint singleton chains and allow them to be constructed in parallel. Currently, we take a lock on Injector.class for constructing singletons. This is pretty bad. Firstly we only need to take a lock per injector tree (i.e. all child injectors must lock on the same lock as the root injector), this helps disjoint injector trees live in the same process in parallel (or, live happily in the forest =). Secondly, we can apply the same principle to singleton object graphs that are disjoint. This allows multiple threads to run concurrently in the same injector tree (for example, creating + starting n number of rpc servers). -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/google-guice-dev?hl=en -~----------~----~----~----~------~----~------~--~---
