netdpb commented on revision r1041 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=1041
General Comment:
I'll commit a new change that addresses your comments, and moves multimap
bindings into an installed private (not Private) module.
Line-by-line comments:
File:
/trunk/extensions/multibindings/src/com/google/inject/multibindings/MapBinder.java
(r1041)
===============================================================================
Line 198: Types.setOf(newParameterizedType(Provider.class,
valueType.getType()))));
-------------------------------------------------------------------------------
Changed to Types.providerOf throughout.
Line 221: * <ul>
-------------------------------------------------------------------------------
Sure.
Line 391:
entry.setValue(Collections.unmodifiableSet(entry.getValue()));
-------------------------------------------------------------------------------
Used ImmutableSet and ImmutableMap throughout where I could.
Line 399: throw new ProvisionException("no binding for " +
providerMultimapKey
-------------------------------------------------------------------------------
No longer necessary in the change I'm about to upload.
Line 424: multimap.put(key,
Collections.unmodifiableSet(values));
-------------------------------------------------------------------------------
Are you sure? Line 400 prevents null values, doesn't it?
Respond to these comments at
http://code.google.com/p/google-guice/source/detail?r=1041
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
