b0b0b0b commented on revision r523 in project google-guice. Details are at http://code.google.com/p/google-guice/source/detail?r=523
Score: Neutral General Comment: I'm not commenting on the changeset so much as asking a q about one line of code. Line-by-line comments: File: /trunk/src/com/google/inject/spi/SourceProviders.java (r523) =============================================================================== Line 71: static ThreadLocal<SourceProvider[]> localSourceProvider = ------------------------------------------------------------------------------- Will this threadlocal pin a classloader in memory (if threads having a value for the local source provider are not stopped) which would otherwise be collectible? Respond to these comments at http://code.google.com/p/google-guice/source/detail?r=523 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/google-guice-dev?hl=en -~----------~----~----~----~------~----~------~--~---
