limpbizkit commented on revision r1118 in project google-guice. Details are at http://code.google.com/p/google-guice/source/detail?r=1118
Score: Positive Line-by-line comments: File: /trunk/servlet/src/com/google/inject/servlet/FilterChainInvocation.java (r1118) =============================================================================== Line 44: public FilterChainInvocation(FilterDefinition[] filterDefinitions, ------------------------------------------------------------------------------- consider taking a list in and doing the clone internally? I don't like arrays on API boundaries because it's not always clear whether the caller has rights to mutate Respond to these comments at http://code.google.com/p/google-guice/source/detail?r=1118 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/google-guice-dev?hl=en -~----------~----~----~----~------~----~------~--~---
