limpbizkit commented on revision r1136 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=1136

Score: Positive


Line-by-line comments:

File: /trunk/src/com/google/inject/Binder.java (r1136)
===============================================================================

Line 176:  *         .toConstructor(loneCtor);</pre>
-------------------------------------------------------------------------------
you might also wanna note what I said on the ToConstructor wiki doc,

   "Each toConstructor() binding is scoped independently. If you create  
multiple singleton bindings that target the same constructor, each binding  
yields its own instance.

Respond to these comments at  
http://code.google.com/p/google-guice/source/detail?r=1136
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings

--

You received this message because you are subscribed to the Google Groups 
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/google-guice-dev?hl=en.


Reply via email to