waldheinz commented on revision r1049 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=1049
Score: Positive
Line-by-line comments:
File: /trunk/src/com/google/inject/util/Node.java (r1049)
===============================================================================
Line 52: void setScopeRank(int rank, Class<? extends Annotation>
annotation) {
-------------------------------------------------------------------------------
"Called at most once per node." -- I'd assert that, although it seems to
hold for the current ScopeChecker implementation.
Respond to these comments at
http://code.google.com/p/google-guice/source/detail?r=1049
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en.