limpbizkit commented on revision r1195 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=1195

Score: Neutral


Line-by-line comments:

File: /trunk/src/com/google/inject/util/Modules.java (r1195)
===============================================================================

Line 73: public static PrivateOverriddenModuleBuilder override(PrivateModule privateModule) {
-------------------------------------------------------------------------------
Does this need a new public method? It means things don't work if your compile-time type disagrees with the runtime type

Respond to these comments at http://code.google.com/p/google-guice/source/detail?r=1195
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/google-guice-dev?hl=en.

Reply via email to