Comment #2 on issue 526 by [email protected]: Followup matters to r1185
http://code.google.com/p/google-guice/issues/detail?id=526
Thanks, you've applied most of my suggestions.
However, the dependency of c.g.i.i.util.StackTraceElements on
c.g.i.i.MoreTypes remains.
My suggestion (which I didn't explain very clearly, sorry) is to move
MoreTypes.memberType and MoreTypes.toString to c.g.i.i.util.Classes.
Not only does this break the last (non-annotation) dependency of the
internal.util package on the main package, it also neatly removes from
MoreTypes these two methods which have nothing to do with generic Types and
the rest of the MoreTypes class.
Not essential, I'll agree, but it does neatly finalize the demarcation
between internal and internal.util.
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en.
