[email protected] commented on revision r1221 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=1221
Score: Positive
General Comment:
public void init(FilterConfig filterConfig) throws ServletException {
workManager.startPersistence();
}
Could this job be performed in the doFilter method when the first request
arrives instead of the init method when app is initialized?
i.e something like:
private boolean initialized = false;
public void doFilter(final ServletRequest servletRequest, final
ServletResponse servletResponse,
final FilterChain filterChain) throws IOException, ServletException {
if (!initialized) {
workManager.startPersistence();
initialized = true;
}
filterChain.doFilter(servletRequest, servletResponse);
}
Respond to these comments at
http://code.google.com/p/google-guice/source/detail?r=1221
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en.
