sberlin commented on revision r1230 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=1230
Score: Positive
Line-by-line comments:
File:
/trunk/extensions/servlet/src/com/google/inject/servlet/ServletScopes.java
(r1230)
===============================================================================
Line 134: private HttpServletRequest request =
-------------------------------------------------------------------------------
should this fail early if GuiceFilter.getRequest is null (or will it never
be null and instead OutOfScopeException will be thrown?, or will
HttpRequestServletWrapper throw an NPE?), or maybe just log a warning?
Line 139: if (null == context) {
-------------------------------------------------------------------------------
if context != null, should it fail or log a warning? (are there usecases
for running it in a thread where a context already exists and preserving
that thread's context?)
Respond to these comments at
http://code.google.com/p/google-guice/source/detail?r=1230
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en.
