[email protected] commented on revision r1206 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=1206
Score: Positive
General Comment:
I love it. So simple.
Line-by-line comments:
File: /trunk/src/com/google/inject/spi/ProviderWithExtensionVisitor.java
(r1206)
===============================================================================
Line 26: * When an extension binds a provider instance, the provider can
implement this
-------------------------------------------------------------------------------
<p>
Line 32: * <code>
-------------------------------------------------------------------------------
Use {...@code ...} to prevent your <V, B> generics from being vacuumed up by
Javadoc
Line 57: * Due to issues with generics, the type parameters of this
method do not
-------------------------------------------------------------------------------
<p>
Respond to these comments at
http://code.google.com/p/google-guice/source/detail?r=1206
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en.
