[email protected] commented on revision r1254 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=1254
Score: Positive
Line-by-line comments:
File:
/trunk/extensions/servlet/src/com/google/inject/servlet/ServletScopes.java
(r1254)
===============================================================================
Line 50: // Should we use the alternate request scope, if no http
request
-------------------------------------------------------------------------------
NOTE(dhanji) or TODO(dhanji)?
Line 172: for (Map.Entry<Key<?>, Object> entry : seedMap.entrySet()) {
-------------------------------------------------------------------------------
nice
Line 182: "Cannot continue request in the same thread as a HTTP
request!");
-------------------------------------------------------------------------------
a -> an
Line 223: Preconditions.checkArgument(null != seedMap,
-------------------------------------------------------------------------------
maybe move this bit of code (duplicated with above) to a small static
method.
Respond to these comments at
http://code.google.com/p/google-guice/source/detail?r=1254
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en.
