Comment #5 on issue 544 by mathieu.carbou: Guice servlet module crashed when used with Elements.getElements()
http://code.google.com/p/google-guice/issues/detail?id=544

Note that for the regression, the issue is not specific to guice-servlets. All Guice modules using states like ServletsModuleBuilder have this potential crash issue because the introspection through Elemnts.getElements() could modify these states.

This is the case for:

http://code.google.com/p/googl-guice/source/browse/trunk/extensions/servlet/src/com/google/inject/servlet/ServletsModuleBuilder.java

If i check the revisions of this class, the bug has been introduced by this commit:

r802            
Error checking for duplicate URI pattern mapping (servlets only).
Jan 06, 2009    
dhanji

This is when the check has been added.

But to my mind, this is not a bad commit: I think this check MUST occur.

My point is that before calling the configureServlets() method, you first should ensure that the two lists are empty.

--
You received this message because you are subscribed to the Google Groups 
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/google-guice-dev?hl=en.

Reply via email to