jessewil...@google.com commented on revision r1324 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=1324

Score: Positive

General Comment:
I'm still not particularly happy with including $Nullable in the base check. It means 2x as many checks in production code in order to satisfy one unit test.

It might be simpler to just hack the unit test to bail if Nullable.class.getName() starts with "$".

Respond to these comments at http://code.google.com/p/google-guice/source/detail?r=1324

--
You received this message because you are subscribed to the Google Groups 
"google-guice-dev" group.
To post to this group, send email to google-guice-...@googlegroups.com.
To unsubscribe from this group, send email to 
google-guice-dev+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-guice-dev?hl=en.

Reply via email to