Revision: 1328
Author: sberlin
Date: Sat Oct 30 07:15:06 2010
Log: issue 531 -- don't let c.g.i.internal.util reference outside its
package.
http://code.google.com/p/google-guice/source/detail?r=1328
Modified:
/trunk/core/src/com/google/inject/internal/Errors.java
/trunk/core/src/com/google/inject/internal/MoreTypes.java
/trunk/core/src/com/google/inject/internal/util/Classes.java
/trunk/core/src/com/google/inject/internal/util/StackTraceElements.java
/trunk/core/src/com/google/inject/spi/InjectionPoint.java
/trunk/extensions/throwingproviders/test/com/google/inject/throwingproviders/ThrowingProviderBinderTest.java
=======================================
--- /trunk/core/src/com/google/inject/internal/Errors.java Sun Oct 24
21:56:00 2010
+++ /trunk/core/src/com/google/inject/internal/Errors.java Sat Oct 30
07:15:06 2010
@@ -24,6 +24,7 @@
import com.google.inject.ProvisionException;
import com.google.inject.Scope;
import com.google.inject.TypeLiteral;
+import com.google.inject.internal.util.Classes;
import com.google.inject.internal.util.ImmutableList;
import com.google.inject.internal.util.ImmutableSet;
import com.google.inject.internal.util.Lists;
@@ -626,7 +627,7 @@
},
new Converter<Member>(Member.class) {
public String toString(Member member) {
- return MoreTypes.toString(member);
+ return Classes.toString(member);
}
},
new Converter<Key>(Key.class) {
@@ -683,7 +684,7 @@
public static void formatInjectionPoint(Formatter formatter,
Dependency<?> dependency,
InjectionPoint injectionPoint) {
Member member = injectionPoint.getMember();
- Class<? extends Member> memberType = MoreTypes.memberType(member);
+ Class<? extends Member> memberType = Classes.memberType(member);
if (memberType == Field.class) {
dependency = injectionPoint.getDependencies().get(0);
=======================================
--- /trunk/core/src/com/google/inject/internal/MoreTypes.java Sun Aug 1
12:38:28 2010
+++ /trunk/core/src/com/google/inject/internal/MoreTypes.java Sat Oct 30
07:15:06 2010
@@ -26,12 +26,8 @@
import com.google.inject.util.Types;
import java.io.Serializable;
import java.lang.reflect.Array;
-import java.lang.reflect.Constructor;
-import java.lang.reflect.Field;
import java.lang.reflect.GenericArrayType;
import java.lang.reflect.GenericDeclaration;
-import java.lang.reflect.Member;
-import java.lang.reflect.Method;
import java.lang.reflect.ParameterizedType;
import java.lang.reflect.Type;
import java.lang.reflect.TypeVariable;
@@ -246,45 +242,6 @@
public static String typeToString(Type type) {
return type instanceof Class ? ((Class) type).getName() :
type.toString();
}
-
- /**
- * Returns {...@code Field.class}, {...@code Method.class} or {...@code
Constructor.class}.
- */
- public static Class<? extends Member> memberType(Member member) {
- checkNotNull(member, "member");
-
- if (member instanceof Field) {
- return Field.class;
-
- } else if (member instanceof Method) {
- return Method.class;
-
- } else if (member instanceof Constructor) {
- return Constructor.class;
-
- } else {
- throw new IllegalArgumentException(
- "Unsupported implementation class for Member, " +
member.getClass());
- }
- }
-
- /**
- * Formats a member as concise string, such as {...@code
java.util.ArrayList.size},
- * {...@code java.util.ArrayList<init>()} or {...@code
java.util.List.remove()}.
- */
- public static String toString(Member member) {
- Class<? extends Member> memberType = memberType(member);
-
- if (memberType == Method.class) {
- return member.getDeclaringClass().getName() + "." + member.getName()
+ "()";
- } else if (memberType == Field.class) {
- return member.getDeclaringClass().getName() + "." + member.getName();
- } else if (memberType == Constructor.class) {
- return member.getDeclaringClass().getName() + ".<init>()";
- } else {
- throw new AssertionError();
- }
- }
/**
* Returns the generic supertype for {...@code supertype}. For example,
given a class {...@code
=======================================
--- /trunk/core/src/com/google/inject/internal/util/Classes.java Sat Jul 3
08:51:31 2010
+++ /trunk/core/src/com/google/inject/internal/util/Classes.java Sat Oct 30
07:15:06 2010
@@ -16,8 +16,15 @@
package com.google.inject.internal.util;
+import static com.google.inject.internal.util.Preconditions.checkNotNull;
+
+import java.lang.reflect.Constructor;
+import java.lang.reflect.Field;
+import java.lang.reflect.Member;
+import java.lang.reflect.Method;
import java.lang.reflect.Modifier;
+
/**
* Class utilities.
*/
@@ -32,4 +39,43 @@
int modifiers = clazz.getModifiers();
return !clazz.isInterface() && !Modifier.isAbstract(modifiers);
}
-}
+
+ /**
+ * Formats a member as concise string, such as {...@code
java.util.ArrayList.size},
+ * {...@code java.util.ArrayList<init>()} or {...@code
java.util.List.remove()}.
+ */
+ public static String toString(Member member) {
+ Class<? extends Member> memberType = Classes.memberType(member);
+
+ if (memberType == Method.class) {
+ return member.getDeclaringClass().getName() + "." + member.getName()
+ "()";
+ } else if (memberType == Field.class) {
+ return member.getDeclaringClass().getName() + "." + member.getName();
+ } else if (memberType == Constructor.class) {
+ return member.getDeclaringClass().getName() + ".<init>()";
+ } else {
+ throw new AssertionError();
+ }
+ }
+
+ /**
+ * Returns {...@code Field.class}, {...@code Method.class} or {...@code
Constructor.class}.
+ */
+ public static Class<? extends Member> memberType(Member member) {
+ checkNotNull(member, "member");
+
+ if (member instanceof Field) {
+ return Field.class;
+
+ } else if (member instanceof Method) {
+ return Method.class;
+
+ } else if (member instanceof Constructor) {
+ return Constructor.class;
+
+ } else {
+ throw new IllegalArgumentException(
+ "Unsupported implementation class for Member, " +
member.getClass());
+ }
+ }
+}
=======================================
--- /trunk/core/src/com/google/inject/internal/util/StackTraceElements.java
Sun Aug 1 12:23:10 2010
+++ /trunk/core/src/com/google/inject/internal/util/StackTraceElements.java
Sat Oct 30 07:15:06 2010
@@ -16,7 +16,6 @@
package com.google.inject.internal.util;
-import com.google.inject.internal.MoreTypes;
import java.io.IOException;
import java.lang.reflect.Constructor;
import java.lang.reflect.Member;
@@ -61,7 +60,7 @@
int lineNumber = -1;
end[NO_AOP]*/
- Class<? extends Member> memberType = MoreTypes.memberType(member);
+ Class<? extends Member> memberType = Classes.memberType(member);
String memberName = memberType == Constructor.class ? "<init>" :
member.getName();
return new StackTraceElement(declaringClass.getName(), memberName,
fileName, lineNumber);
}
=======================================
--- /trunk/core/src/com/google/inject/spi/InjectionPoint.java Sat Jul 3
08:51:31 2010
+++ /trunk/core/src/com/google/inject/spi/InjectionPoint.java Sat Oct 30
07:15:06 2010
@@ -23,9 +23,9 @@
import com.google.inject.internal.Annotations;
import com.google.inject.internal.Errors;
import com.google.inject.internal.ErrorsException;
-import com.google.inject.internal.MoreTypes;
import static com.google.inject.internal.MoreTypes.getRawType;
import com.google.inject.internal.Nullability;
+import com.google.inject.internal.util.Classes;
import com.google.inject.internal.util.ImmutableList;
import com.google.inject.internal.util.ImmutableSet;
import com.google.inject.internal.util.Lists;
@@ -191,7 +191,7 @@
}
@Override public String toString() {
- return MoreTypes.toString(member);
+ return Classes.toString(member);
}
/**
=======================================
---
/trunk/extensions/throwingproviders/test/com/google/inject/throwingproviders/ThrowingProviderBinderTest.java
Sun Oct 24 14:36:39 2010
+++
/trunk/extensions/throwingproviders/test/com/google/inject/throwingproviders/ThrowingProviderBinderTest.java
Sat Oct 30 07:15:06 2010
@@ -24,7 +24,7 @@
import com.google.inject.Injector;
import com.google.inject.Key;
import com.google.inject.TypeLiteral;
-import com.google.inject.internal.MoreTypes;
+import com.google.inject.internal.util.Classes;
import com.google.inject.internal.util.Function;
import com.google.inject.internal.util.ImmutableList;
import com.google.inject.internal.util.ImmutableSet;
@@ -729,7 +729,7 @@
fail();
} catch(CreationException ce) {
assertEquals(OneNoneGetMethod.class.getName()
- + " may not declare any new methods, but declared " +
MoreTypes.toString(OneNoneGetMethod.class.getDeclaredMethods()[0]),
+ + " may not declare any new methods, but declared " +
Classes.toString(OneNoneGetMethod.class.getDeclaredMethods()[0]),
Iterables.getOnlyElement(ce.getErrorMessages()).getMessage());
}
}
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en.
