Comment by [email protected]:
Score: Positive
Line-by-line comments:
File: /trunk/core/src/com/google/inject/internal/BindingProcessor.java
(r1526)
===============================================================================
Line 163: public Boolean visit(UntargettedBinding<? extends T>
untargetted) {
-------------------------------------------------------------------------------
I think you can simplify this to avoid the ugly phases.
You could move the 'visit(UntargettedBinding)' method into a new
implementation of BindingTargetVisitor. You'd visit the other binding types
first, and then you'd visit the untargetted bindings.
I believe we're using similar strategies to handle injected dependencies
that aren't explicitly bound.
For more information:
http://code.google.com/p/google-guice/source/detail?r=1526
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en.
