Comment #15 on issue 635 by [email protected]: GuiceFilter uses wrong
instance of FilterPipeline if used with multiple servlet context and
multiple injectors
http://code.google.com/p/google-guice/issues/detail?id=635
mcculls,
Usually I'd run that sort of test (ie. more integration test than unit
test) in an isolated classloader or jvm to avoid static clashes elsewhere
in the app or container, but I can see what you're trying to achieve.
That's actually a very good idea though I have a feeling I'm going to have
a hard time convincing the Surefire committers to add such a feature. Doing
this myself on a per-@Test basis sounds painful.
I'm fine with using your patch so long as:
1. Currently MULTIPLE_INJECTORS_WARNING is logged if the static pipeline
value is clobbered. I propose logging this warning only if the clobbered
value actually gets used (this is included in my patch). Otherwise we're
logging warnings that aren't actually relevant.
2. We document how to run multiple instances of GuiceFilter per JVM (my
use-case). If subclassing is required, so be it, so long as we post the
relevant code-sniplet somewhere.
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en.
