Status: New
Owner: ----

New issue 675 by [email protected]: Latest guice-servlet depends on jarjar'd com.google.base.Throwables, but this isn't included in guice core
http://code.google.com/p/google-guice/issues/detail?id=675

See http://groups.google.com/group/google-guice/msg/b4cb1abebae3fe85. I've removed the erroneous annotation from AbstractInjectorGrapherTest - and there's a separate issue for the failing Multibinding test (http://code.google.com/p/google-guice/issues/detail?id=670)

The remaining issue is the failing Servlet tests, which are caused by a new dependency from guice-servlet to com.google.base.Throwables. Unfortunately guice core doesn't jarjar Throwables because it doesn't directly depend on it. So we either need to tweak the build so that Guava classes the are only used by extensions are jarjar'd into the core - or find some way to jarjar the additional classes into the extension jar.

Alternatively we could revisit making Guava an external dependency of Guice - that's the approach we've been experimenting with in sisu-guice, and it has worked out fine so far (thanks to the compatibility between Guava releases).

--
You received this message because you are subscribed to the Google Groups 
"google-guice-dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/google-guice-dev?hl=en.

Reply via email to