Comment #4 on issue 743 by sberlin: Move
constructionContext.removeCurrentReference from
ConstructorInjector.construct to ConstructorInjector.provision?
http://code.google.com/p/google-guice/issues/detail?id=743
FYI, things are looking pretty good, I don't see any breakages from the
change so far, so I'm inclined to commit it. FWIW, I rewrote the test a
bit so it doesn't require assistedinject. See below
--
public void testProvisionIsNotifiedAfterContextsClear() {
Injector injector = Guice.createInjector(new AbstractModule() {
@Override
protected void configure() {
bindListener(Matchers.any(), new ProvisionListener() {
@Override
public <T> void onProvision(ProvisionInvocation<T> provision) {
Object provisioned = provision.provision();
if (provisioned instanceof X) {
((X)provisioned).init();
} else if (provisioned instanceof Y) {
X.createY = false;
((Y)provisioned).init();
}
}
});
}
});
X.createY = true;
X x = injector.getInstance(X.class);
assertNotSame(x, x.y.x);
assertFalse("x.ID: " + x.ID + ", x.y.x.iD: " + x.y.x.ID, x.ID ==
x.y.x.ID);
}
private static class X {
final static Random RND = new Random();
static boolean createY;
final int ID = RND.nextInt();
final Provider<Y> yProvider;
Y y;
@Inject X(Provider<Y> yProvider) {
this.yProvider = yProvider;
}
void init() {
if (createY) {
this.y = yProvider.get();
}
}
}
private static class Y {
final Provider<X> xProvider;
X x;
@Inject Y(Provider<X> xProvider) {
this.xProvider = xProvider;
}
void init() {
this.x = xProvider.get();
}
}
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice-dev?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
