Comment #4 on issue 759 by [email protected]: Use ASM 4.1
http://code.google.com/p/google-guice/issues/detail?id=759
With the one-line CGLIB patch from comment #2 the ASM dependency can be
bumped to 4.1 as follows:
diff --git a/core/pom.xml b/core/pom.xml
index 328af17..52e64e8 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -15,7 +15,7 @@
<properties>
<cglib.version>3.0</cglib.version>
- <asm.version>4.0</asm.version>
+ <asm.version>4.1</asm.version>
</properties>
<dependencies>
@@ -35,6 +35,11 @@
<version>11.0.1</version>
</dependency>
<dependency>
+ <groupId>org.ow2.asm</groupId>
+ <artifactId>asm</artifactId>
+ <version>${asm.version}</version>
+ </dependency>
+ <dependency>
<groupId>cglib</groupId>
<artifactId>cglib</artifactId>
<version>${cglib.version}</version>
@@ -220,6 +225,12 @@
| Mark as optional: embedded by JarJar
-->
<dependency>
+ <groupId>org.ow2.asm</groupId>
+ <artifactId>asm</artifactId>
+ <version>${asm.version}</version>
+ <optional>true</optional>
+ </dependency>
+ <dependency>
<groupId>cglib</groupId>
<artifactId>cglib</artifactId>
<version>${cglib.version}</version>
Although as CGLIB will need to be patched then we might as well update the
ASM dependency there to 4.1, in which case the only change needed in Guice
would then be:
diff --git a/core/pom.xml b/core/pom.xml
index 328af17..52e64e8 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -15,7 +15,7 @@
<properties>
<cglib.version>3.0</cglib.version>
- <asm.version>4.0</asm.version>
+ <asm.version>4.1</asm.version>
</properties>
<dependencies>
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice-dev.
For more options, visit https://groups.google.com/groups/opt_out.
