Comment #10 on issue 757 by [email protected]: Java 8 lambda definitions can break Guice's internal exception handling
http://code.google.com/p/google-guice/issues/detail?id=757

Coming from related issue: http://code.google.com/p/google-guice/issues/detail?id=782

The error is inside ASM itself, trying to read the class from the bytes of the classfile. We could potentially put a try/catch around that for IAE, but I'm
not a big fan of defensively programming

In my cases ASM only fails for reverse lookups of original source code locations. So on _any_ Guice error I only receive an completely unrelated $ComputedExceptions hiding another unrelated IllegalArgumentException instead of any helpful pointer to the original issue, just because ASM/Guice was unable to resolve the assumed root code line for the exception I do not get any clue about. ;-)

I'd vote for better defense in here, because it's located in the crucial error handling.

Please find attached a small patch against 4.0-beta which makes this part more robust in these error cases and simply omits the line number then.

Attachments:
        0001-Do-not-hide-root-exceptions-on-ASM-Java8-errors.patch  1.9 KB

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"google-guice-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice-dev.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to