Comment #101 on issue 288 by [email protected]: FinalizableReferenceQueue
still leaks
http://code.google.com/p/google-guice/issues/detail?id=288
I see that there have been multiple attempts to fix the localContext
variable in the InjectorImpl. But sadly they all fail to solve the issue
completely and specially in a Servlet container.
In tomcat there is still a warning (also in 4.0-beta) because the
ThreadLocal is not cleared (the object[] is still leaked into the Threads).
With the current JVM's it requires a new ThreadLocal to do something to
finally garbage collect ThreadLocal's values from the Thread class and
each thread needs to get hit with that new ThreadLocal to completely
cleanup the mess left behind by other ThreadLocal's this can take some time
for an application server like tomcat because it can run 100+ Thread's and
there is no guarantee that the Thread will ever hit a new ThreadLocal.
To solve these issues we need to clear the ThreadLocal and must not use a
library/application extends class to initialize the ThreadLocal.
The attached patch file removes the LocalContextThreadLocal, removes the
unnecessary Object[] and clears the ThreadLocal.
Attachments:
ThreadLocalFix-guice.patch 1.8 KB
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice-dev.
For more options, visit https://groups.google.com/groups/opt_out.
