Comment #34 on issue 372 by sberlin: GuiceFilter breaks dispatching to jsp if jasper is being used to compile the jsp
http://code.google.com/p/google-guice/issues/detail?id=372

I have a few questions about the patch:
1) Should pathInfo.contains(servletPath) instead be pathInfo.startsWith(servletPath)? That seems safer and it passes the test, but I don't know the intent. 2) The comment says (paraphrased) "If pathInfo doesn't contain servletPath ... then return null". But the code doesn't do that. The code returns pathInfo as-is (with the contextPath stripped) if it doesn't contain the servlet path. Is that intended?

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"google-guice-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice-dev.
For more options, visit https://groups.google.com/d/optout.

Reply via email to