Status: New
Owner: ----

New issue 806 by [email protected]: ContinuingHttpServletRequest: Make cookies immutable
http://code.google.com/p/google-guice/issues/detail?id=806

Description of the issue:

Cookies are lost in Ccontinued background thread in ontinuingHttpServletRequest.

The whole purpose of request scope propagation is to make a
snapshot of the request.  To the snapshot belong all attributes
and cookies. Cookies are mutable and were erroneously not frozen.

Note this TODO comment in the corresponding code:

// TODO(dhanji): Cookies themselves are mutable. Is this a problem?

This breaks web session management in Gerrit Code review project.

Steps to reproduce: [1]

[1] https://gerrit-review.googlesource.com/57284


Attachments:
        0001-Guice-Servlet-Fix-request-propagation-problem.patch  2.8 KB

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"google-guice-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice-dev.
For more options, visit https://groups.google.com/d/optout.

Reply via email to