Comment by sberlin:
Score: Positive
General Comment:
few nits on the tests, but LGTM. thanks, Dhanji!
Line-by-line comments:
File:
/extensions/servlet/test/com/google/inject/servlet/ContinuingHttpServletRequestTest.java
(r3b02622e856e845f9bc5353a494b5ccc75dec40c)
===============================================================================
Line 66: fail();
-------------------------------------------------------------------------------
i think it'd be marginally better to validate that the continued cookies
still equal what the original used to be (after modifying the original), as
opposed to just that they aren't equal to the modified ones.
Line 89: private static void assertCookiequality(Cookie one, Cookie two) {
-------------------------------------------------------------------------------
s/cookiequality/cookieEquality
For more information:
https://code.google.com/p/google-guice/source/detail?r=3b02622e856e845f9bc5353a494b5ccc75dec40c
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice-dev.
For more options, visit https://groups.google.com/d/optout.
