Comment by sberlin:
Score: Neutral
General Comment:
needs tests that would have failed prior to fixing the problems here (as
well as the problems described in issue 788).
Line-by-line comments:
File: /core/src/com/google/inject/matcher/Matchers.java
(r38120b77a32674256dd5092278a84c52eeb20398)
===============================================================================
Line 404: * Returns a matcher which matches a method of identical
signature.
-------------------------------------------------------------------------------
describe if it requires generics to match also.
Line 419: return name.equals(method.getName()) && Arrays.equals(args,
method.getParameterTypes());
-------------------------------------------------------------------------------
check return type?
File: /extensions/persist/src/com/google/inject/persist/PersistModule.java
(r38120b77a32674256dd5092278a84c52eeb20398)
===============================================================================
Line 50: jloMethods.and(withSignature(method));
-------------------------------------------------------------------------------
should this be "or" instead? otherwise i don't see how it could possibly
ever pass. a method can't have more than one signature.
also: should this be 'getDeclaredMethods' instead
of 'getMethods'? 'getMethods' just returns public ones, so this
skip 'finalize', & 'clone'.
also: this is a neat way of building it up, but seems like it's going to
add some constant overhead to every method call. there's 11 methods in
Object, so assuming this is fixed to use 'or', it'll have to check the
signature against 11 methods every time any method is called. might just
be necessary, but maybe there's a better/faster way to do it?
For more information:
https://code.google.com/p/google-guice/source/detail?r=38120b77a32674256dd5092278a84c52eeb20398
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice-dev.
For more options, visit https://groups.google.com/d/optout.
