Comment #5 on issue 807 by [email protected]: FilterDefinition should
wrap the servlet request like ServletDefinition
http://code.google.com/p/google-guice/issues/detail?id=807
I've attached a patch which wraps the servlet request before filter
execution using code hijacked from ServletDefinition. I'm not sure if this
is 100% correct (i.e. REQUEST_DISPATCHER_REQUEST attribute) but this change
provides my filters with the correct path info.
This change required a tweak to a unit test to retrieve the inner (I
hesitate to say original) request for identity comparison.
Unfortunately, this patch also includes a regression (doh!) in:
FilterDispatchIntegrationTest.testDispatchFilterPipelineWithRegexMatching
I haven't figured out why this is the case yet. When debugging the test,
successful test conditions are met - but it fails at what seems to be an
unusual place - no doubt due to EasyMock proxy generation which I am
unfamiliar with. There is a subtle detail here which is escaping me.
Attachments:
fix_issue_807.patch 6.4 KB
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice-dev.
For more options, visit https://groups.google.com/d/optout.
