Branch:
refs/heads/moe_writing_branch_from_5b65f8c4dcf95a89d3b5ace2dbee3e54fa963722
Home: https://github.com/google/guice
Commit: 22b172d7223a804b4c04a8d7283c9da98c437ab4
https://github.com/google/guice/commit/22b172d7223a804b4c04a8d7283c9da98c437ab4
Author: Sam Berlin <[email protected]>
Date: 2014-08-06 (Wed, 06 Aug 2014)
Changed paths:
M
extensions/multibindings/src/com/google/inject/multibindings/OptionalBinder.java
Log Message:
-----------
OptionalBinder: Make Optional<Provider> anonymous provider an inner class so
that @Inject members can be referenced by generated code for injection (Gelly).
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=71634136
Commit: ef18f6a6072db914a719bad8377eb00dbf2ab3ef
https://github.com/google/guice/commit/ef18f6a6072db914a719bad8377eb00dbf2ab3ef
Author: Sam Berlin <[email protected]>
Date: 2014-08-06 (Wed, 06 Aug 2014)
Changed paths:
M core/src/com/google/inject/internal/InjectorImpl.java
M core/test/com/google/inject/ImplicitBindingTest.java
Log Message:
-----------
Guice: Fix for issue 295 (@ProvidedBy doesn't work with enums)
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=72100195
Commit: c1b732f71eeb9e4e1fb4443173289104c5b340f2
https://github.com/google/guice/commit/c1b732f71eeb9e4e1fb4443173289104c5b340f2
Author: Sam Berlin <[email protected]>
Date: 2014-08-06 (Wed, 06 Aug 2014)
Changed paths:
M core/src/com/google/inject/internal/MoreTypes.java
Log Message:
-----------
Fix typo in JavaDoc for c.g.inject.internal.MoreTypes#getGenericSupertype
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=72545394
Commit: de7fe451c99ba2b8065d9a8d660c2c46cf4d406e
https://github.com/google/guice/commit/de7fe451c99ba2b8065d9a8d660c2c46cf4d406e
Author: Sam Berlin <[email protected]>
Date: 2014-08-06 (Wed, 06 Aug 2014)
Changed paths:
M core/src/com/google/inject/Key.java
M core/src/com/google/inject/internal/BindingBuilder.java
M core/src/com/google/inject/internal/BindingImpl.java
M core/src/com/google/inject/internal/ConstructorBindingImpl.java
M core/src/com/google/inject/internal/InstanceBindingImpl.java
M core/src/com/google/inject/internal/LinkedBindingImpl.java
M core/src/com/google/inject/internal/LinkedProviderBindingImpl.java
M core/src/com/google/inject/internal/ProviderInstanceBindingImpl.java
R core/src/com/google/inject/internal/RehashableKeys.java
M core/src/com/google/inject/internal/UntargettedBindingImpl.java
M core/src/com/google/inject/internal/WeakKeySet.java
M core/src/com/google/inject/spi/Elements.java
M core/src/com/google/inject/spi/ProviderLookup.java
M core/test/com/google/inject/AllTests.java
R core/test/com/google/inject/internal/RehashableKeysTest.java
M extensions/multibindings/src/com/google/inject/multibindings/Element.java
A extensions/multibindings/src/com/google/inject/multibindings/Indexer.java
M
extensions/multibindings/src/com/google/inject/multibindings/MapBinder.java
M
extensions/multibindings/src/com/google/inject/multibindings/Multibinder.java
M
extensions/multibindings/src/com/google/inject/multibindings/RealElement.java
M
extensions/multibindings/test/com/google/inject/multibindings/AllTests.java
M
extensions/multibindings/test/com/google/inject/multibindings/MapBinderTest.java
M
extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
M
extensions/multibindings/test/com/google/inject/multibindings/OptionalBinderTest.java
A
extensions/multibindings/test/com/google/inject/multibindings/RealElementTest.java
M
extensions/multibindings/test/com/google/inject/multibindings/SpiUtils.java
Log Message:
-----------
Implement binding deduplication for multibinder & mapbinder in a different
way.
Instead of relying on Guice binding deduplication (and hacking up RealElement
to break the annotation contract to do so, causing weirdness in WeakKeySet &
forcing us to care about "rehashing keys"), we instead deduplicate within
Multibinder. The downside of this is that toInstance or toProvider(instance)
bindings that are deduplicated will remain in the object graph but effectively
be unreachable. However, that's a downside I'm willing to live with to remove
this hack.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=72570932
Commit: 127d91ac5ec7f504b9cdc254df84269847421c45
https://github.com/google/guice/commit/127d91ac5ec7f504b9cdc254df84269847421c45
Author: Sam Berlin <[email protected]>
Date: 2014-08-06 (Wed, 06 Aug 2014)
Changed paths:
M
extensions/multibindings/src/com/google/inject/multibindings/MapBinder.java
Log Message:
-----------
Guice Multibindings: convert multibinding anonymous providers into
package-private inner classes so that @Inject methods can be referenced by
generated code.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=72598956
Compare: https://github.com/google/guice/compare/22b172d7223a^...127d91ac5ec7
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice-dev.
For more options, visit https://groups.google.com/d/optout.
