Branch: refs/heads/master
Home: https://github.com/google/guice
Commit: 03c2bbf0b7c9f5e7502a04acc5aa85f7d55ce4da
https://github.com/google/guice/commit/03c2bbf0b7c9f5e7502a04acc5aa85f7d55ce4da
Author: cgdecker <[email protected]>
Date: 2014-10-27 (Mon, 27 Oct 2014)
Changed paths:
M jdk8-tests/pom.xml
Log Message:
-----------
Change ${parent.version} to ${project.version} since Maven apparently
complains about ${parent.version}.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=78201599
Commit: d7aa953d088f4955789051414bcd6134437afa17
https://github.com/google/guice/commit/d7aa953d088f4955789051414bcd6134437afa17
Author: timofeyb <[email protected]>
Date: 2014-10-27 (Mon, 27 Oct 2014)
Changed paths:
M core/src/com/google/inject/Scopes.java
M core/src/com/google/inject/internal/InheritingState.java
M core/src/com/google/inject/internal/Scoping.java
A core/src/com/google/inject/internal/SingletonScope.java
M core/src/com/google/inject/internal/State.java
M core/test/com/google/inject/ScopesTest.java
M core/test/com/google/inject/internal/WeakKeySetTest.java
Log Message:
-----------
Making Singleton's creation lock less coarse.
Singleton is defined as a scope which creates no more than one
object per injector. It's highly confusing when you catch a deadlock
between two unrelated injectors due to the same class injection.
Problem is demonstrated using a test that recreates scenario when
one thread injecting class can block other thread to use its own
injector.
Proposed solution is to use Injector-wide locks in a singleton.
ThreadLocal as a way to store current state.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=78469951
Commit: 1215316c7bae68bde9133f8fffa43c074c156633
https://github.com/google/guice/commit/1215316c7bae68bde9133f8fffa43c074c156633
Author: Sam Berlin <[email protected]>
Date: 2014-10-28 (Tue, 28 Oct 2014)
Changed paths:
M core/src/com/google/inject/Scopes.java
M core/src/com/google/inject/internal/InheritingState.java
M core/src/com/google/inject/internal/Scoping.java
A core/src/com/google/inject/internal/SingletonScope.java
M core/src/com/google/inject/internal/State.java
M core/test/com/google/inject/ScopesTest.java
M core/test/com/google/inject/internal/WeakKeySetTest.java
M jdk8-tests/pom.xml
Log Message:
-----------
Merge pull request #868 from
google/moe_writing_branch_from_2b4dd1617e61fac3869381e9e7728b488badc5e2
Merge internal changes
Compare: https://github.com/google/guice/compare/377e16136521...1215316c7bae
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice-dev.
For more options, visit https://groups.google.com/d/optout.
