Branch:
refs/heads/moe_writing_branch_from_1215316c7bae68bde9133f8fffa43c074c156633
Home: https://github.com/google/guice
Commit: 9c8b61815fa15ee3457b9c816afe24a6fdaf7014
https://github.com/google/guice/commit/9c8b61815fa15ee3457b9c816afe24a6fdaf7014
Author: flan <[email protected]>
Date: 2014-11-07 (Fri, 07 Nov 2014)
Changed paths:
M
extensions/multibindings/src/com/google/inject/multibindings/Multibinder.java
M
extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
M
extensions/multibindings/test/com/google/inject/multibindings/SpiUtils.java
Log Message:
-----------
Simplifies Multibinder by moving Key generation to RealMultibinder's
constructor.
Tested:
All existing tests pass.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=79159620
Commit: f6189601d44b1ff8143e26337d0704f35f8dc645
https://github.com/google/guice/commit/f6189601d44b1ff8143e26337d0704f35f8dc645
Author: flan <[email protected]>
Date: 2014-11-07 (Fri, 07 Nov 2014)
Changed paths:
M
extensions/multibindings/src/com/google/inject/multibindings/MapBinder.java
Log Message:
-----------
Simplifies MapBinder by moving Key generation to RealMapBinder's constructor.
Tested:
All existing tests pass.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=79160583
Commit: 615fd2bc2397e2966d682759aae2aad7e8a3db1e
https://github.com/google/guice/commit/615fd2bc2397e2966d682759aae2aad7e8a3db1e
Author: flan <[email protected]>
Date: 2014-11-07 (Fri, 07 Nov 2014)
Changed paths:
M
extensions/multibindings/test/com/google/inject/multibindings/SpiUtils.java
Log Message:
-----------
Make SpiUtils tests more accurate by multiplying the expected results instead
of dividing the actual results. Before, some bindings weren't being checked
and this was overlooked by the tests due to rounding down the number of
leftover bindings.
Tested:
All existing tests pass.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=79167431
Commit: bed1413751f54dc6804dcb2a4c28300081788603
https://github.com/google/guice/commit/bed1413751f54dc6804dcb2a4c28300081788603
Author: flan <[email protected]>
Date: 2014-11-07 (Fri, 07 Nov 2014)
Changed paths:
M
extensions/multibindings/src/com/google/inject/multibindings/Multibinder.java
M
extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
M
extensions/multibindings/test/com/google/inject/multibindings/SpiUtils.java
Log Message:
-----------
Adds a binding for Collection<javax.inject.Provider<E>> to Multibinder.
Before, only a Collection<com.google.inject.Provider<E>> was bound; now
both are bound.
Note that this required changes to SpiUtils because MapBinder uses a
Multibinder to bind Set<Entry<K, Provider<V>>. There is a bit of
strangeness here because it means that there is now a binding for
Collection<javax.inject.Provider<Map.Entry<K, Provider<V>>>.
Tested:
All existing and modified tests pass.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=79191051
Commit: 4f6c5672a1a685228d2970fc2dea89484430279f
https://github.com/google/guice/commit/4f6c5672a1a685228d2970fc2dea89484430279f
Author: flan <[email protected]>
Date: 2014-11-07 (Fri, 07 Nov 2014)
Changed paths:
M
extensions/multibindings/test/com/google/inject/multibindings/MapBinderTest.java
Log Message:
-----------
Adds a test that explicitly tests all of the bindings created by MapBinder.
Current tests rely on SpiUtil to validate all bindings, but those tests are
hard to read and reason about; this test is explicit.
Tested:
The new test passes.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=79369985
Commit: 0c3a880d89bda0fe769f9fb422eb212b72934e66
https://github.com/google/guice/commit/0c3a880d89bda0fe769f9fb422eb212b72934e66
Author: Stuart McCulloch <[email protected]>
Date: 2014-11-07 (Fri, 07 Nov 2014)
Changed paths:
M build.xml
M core/src/com/google/inject/internal/BytecodeGen.java
M core/src/com/google/inject/internal/InternalFlags.java
Log Message:
-----------
Robustness: wrap any calls to System.getProperty in case security is enabled.
Since calling System.getProperty may throw an exception on locked-down systems.
Note: this patch has the side-effect of making the 'guice_include_stack_traces'
setting static, rather than querying the system property each time a module is
installed. Making the setting static improves performance as System.getProperty
can be a bottleneck, at the cost of being able to change the setting
on-the-fly.
(This is a slightly modified version of the pull request from #872.)
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=79427020
Compare: https://github.com/google/guice/compare/9c8b61815fa1^...0c3a880d89bd
--
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice-dev.
For more options, visit https://groups.google.com/d/optout.
