> Issue 16: JarJar produces corrupt files
> http://code.google.com/p/jarjar/issues/detail?id=16
>
> Comment #3 by chris.nokleberg:
> Fixed in SVN head.
Yay! :)
Thanks!
Gili
Stuart McCulloch wrote:
> 2008/8/30 Gili Tzabari <[EMAIL PROTECTED]
> <mailto:[EMAIL PROTECTED]>>
>
>
>
> Last time I tried this I noticed that Guice depends on JarJar which
> is broken for JDK 1.6. That is, if you try building under JDK 1.6
> JarJar
> will produce a corrupt JAR file. Has this been fixed?
>
>
> afaik the corrupt jar issue only occurs when jarjar processes
> classes containing 1.6 bytecode - if you set the javac target
> to 1.5 then the problem doesn't occur, even if you're running
> the compilation with a 1.6 JVM (at least with 1.6 update 10)
>
> I've been compiling and using guice with 1.6u10 without any
> problems, once I added the 1.5 source and target settings.
>
> Gili
>
> Stuart McCulloch wrote:
> > 2008/8/30 Leigh Klotz <[EMAIL PROTECTED]
> <mailto:[EMAIL PROTECTED]>
> > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>>
> >
> >
> > I'd like to get started in earnest on Guice and I'm feeling
> the need
> > for some of the new stuff. I ran into this same build
> problem, which
> > is how I got here.
> >
> > How's the summer release looking, now that Labor Day is upon
> us? Or
> > should I just slog through the 20080818 tag compilation in
> JDK 1.5?
> >
> >
> > you should be able to build the latest trunk code with a 1.5 JDK
> >
> > if you want to build it with 1.6 then you need the Update 10 RC
> > from http://java.sun.com/javase/downloads/ea/6u10/6u10RC.jsp
> >
> > you'll also need to add the following lines to "build.properties":
> >
> > ant.build.javac.source=1.5
> > ant.build.javac.target=1.5
> >
> > so the compiler will output 1.5 bytecode, otherwise you'll see zero
> > entries for some classes in the jar (iirc this is due to a bug
> in jarjar)
> >
> > alternatively, you could also set the source/target directly on the
> > two javac tasks in "common.xml" - this will have the same effect.
> >
> > HTH
> >
> > Leigh.
> > > On Jul 14, 3:30 am, "[EMAIL PROTECTED]
> <mailto:[EMAIL PROTECTED]> <mailto:[EMAIL PROTECTED]
> <mailto:[EMAIL PROTECTED]>>"
> > <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
> <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>> wrote:
> > >
> > > > On Jul 13, 11:46 pm, Cow_woC <[EMAIL PROTECTED]
> <mailto:[EMAIL PROTECTED]>
> > <mailto:[EMAIL PROTECTED]
> <mailto:[EMAIL PROTECTED]>>> wrote:
> > ...
> > > > > Are there precompiled builds I can pick up somewhere?
> > >
> > > > I hate to suggest it, but building with JDK 1.5 works fine.
> > >
> > > > We don't have snapshot jars -- but we are planning to do
> > > > a full release during the summer...
> > >
> > > > Cheers,
> > > > Jesse
> >
> >
> > --
> > Cheers, Stuart
> >
> > >
>
>
>
>
>
> --
> Cheers, Stuart
>
> >
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"google-guice" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/google-guice?hl=en
-~----------~----~----~----~------~----~------~--~---
