2008/10/28 Gili <[EMAIL PROTECTED]> > > On Oct 27, 11:38 pm, "Dhanji R. Prasanna" <[EMAIL PROTECTED]> wrote: > > On Tue, Oct 28, 2008 at 2:35 PM, Stuart McCulloch <[EMAIL PROTECTED]> > wrote: > > > firstly, which version of guice is being used? > > Now that you mention it I don't recall. I believe it was v1. I need to > retest now anyway with warp-persist v2 and guice v2 so we'll know for > sure shortly. > > > > secondly, I would fully expect the current trunk to leak classes on a > > > restart > > > because the code to allow unloading of proxies is currently disabled > due > > > to issuehttp://code.google.com/p/google-guice/issues/detail?id=235 > > > > It shouldn't matter, the webapp classloader itself should be gc'ed away. > > This is some other leak, maybe thru Hibernate or commons-logging. > > The Glassfish guy was saying that they reuse threads even after the > webapp dies. So Guice's TLS could potentially keep a strong reference > to classes in the ClassLoader, preventing it from garbage-collecting. > Right? >
Guice v1 definitely has a threadlocal leak in the injector, where it wasn't being removed properly - this was fixed in one of my OSGi patches that Jesse committed to trunk, as it was stopping bundle code from being fully unloaded. so I'd be interested to hear how things are with v2 ( with and without the "guice.custom.loader" system property :) > Gili > -- Cheers, Stuart --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/google-guice?hl=en -~----------~----~----~----~------~----~------~--~---
