Wow, I'm real glad that I didn't have to figure out those POMs.. That's some complicated stuff. I have a few questions about some of them, much of which stems from my complete ignorance of Maven...
core/pom.xml: - There's a dependency on org.sonatype.sisu.inject (v2.2.1) ... why not the actual cglib? I vaguely recall we had a custom patch.. did that never go upstream? Does the sisu.inject use the cglib in our lib? - The list of files excluded for NO_AOP munging is listed in the pom & the ant file. Is there any way both can read from a shared property file instead of duplicating it? persist/pom.xml: - Why the exclusion of DynamicFinderTest? trunk/pom.xml - Why version 5 in the parent element? - What's the dependencyManagement section for? Why does it only list some of the dependencies? (And why does it need to duplicate some things listed in the other poms? And why is there no scope?) - Is there any way for the javadoc to be generated using doclava instead of javadoc? Also, some general questions: - Are the dependency jars the poms are requiring the same as the jars in SVN? - (And, just for completeness, even though you already said you're still going to verify this... are the output jars the same as produced from the ant build?) Thanks again for doing all of this, Stuart! sam On 10/21/10, Stuart McCulloch <[email protected]> wrote: > On 21 October 2010 22:18, Sam Berlin <[email protected]> wrote: > >> Thanks, Stuart! > > > OK, buildable poms are committed and are now building on our CI machine: > > https://grid.sonatype.org/ci/job/Google-Guice/ > > the resulting 3.0-SNAPSHOTs can be found here: > > https://repository.sonatype.org/content/groups/forge/com/google/inject/ > > just one outstanding issue relating to running the OSGi container test in > Maven > (must setup a few system properties before it runs) which I'll address > tomorrow > > I also need to verify consistency of Maven-produced binaries with the Ant > build > > Enjoy! > > sam >> >> On Thu, Oct 21, 2010 at 4:23 PM, Stuart McCulloch >> <[email protected]>wrote: >> >>> On 21 October 2010 20:52, Sam Berlin <[email protected]> wrote: >>> >>>> Ahh, well, given that we're already moving the source to make it easier >>>> for Maven, I say just do it now instead of later. If people are going >>>> to >>>> have moving pains, let's give it to them only once. >>> >>> >>> now that core is moved I'm going to try the new poms with the plain src >>> and test folders >>> - as long as that all builds ok and works in IDEs then I think that's a >>> good compromise >>> >>> so no major structural changes planned, and I'll give people a heads-up >>> if >>> that changes >>> >>> >>>> sam >>>> >>>> >>>> On Thu, Oct 21, 2010 at 3:40 PM, Colin Decker <[email protected]>wrote: >>>> >>>>> I think step 2 would be moving the src and test directories under each >>>>> module to src/main/java and src/test/java. >>>>> >>>>> Colin >>>>> >>>>> >>>>> On Thu, Oct 21, 2010 at 3:37 PM, Sam Berlin <[email protected]> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Thu, Oct 21, 2010 at 2:15 PM, Stuart McCulloch >>>>>> <[email protected]>wrote: >>>>>> >>>>>>> On 21 October 2010 18:36, Sam Berlin <[email protected]> wrote: >>>>>>> >>>>>>>> It would be nice to keep the main source instead of a fork. Stuart, >>>>>>>> I think we're all OK with the patch to re-arrange the sources for >>>>>>>> easier >>>>>>>> maven support. Would you be able to apply your patch? >>>>>>> >>>>>>> >>>>>>> sure, I can do that - I can also fix other build issues at the same >>>>>>> time (like http://code.google.com/p/google-guice/issues/detail?id=555 >>>>>>> ) >>>>>>> >>>>>> >>>>>> SGTM -- I think we do want persist to be a first-class extension, so >>>>>> that would be great. What is step 2 (presumably more controversial).. >>>>>> adding POMs that can built Guice? I think, as Jesse may have >>>>>> mentioned >>>>>> earlier, that so long as the output of the Maven build & Ant build are >>>>>> identical binaries (with the exception of maybe META-INF & whatnot), >>>>>> that >>>>>> we're good with POMs that can build. >>>>>> >>>>>> sam >>>>>> >>>>>> >>>>>>> >>>>>>> Thanks! >>>>>>>> >>>>>>>> sam >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Oct 21, 2010 at 11:37 AM, Andrei Pozolotin < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Stuart, hello: >>>>>>>>> >>>>>>>>> On Oct 18, 3:54 pm, Stuart McCulloch <[email protected]> wrote: >>>>>>>>> > On 18 October 2010 19:25, Brian Pontarelli <[email protected]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>> can you please clarify, what's the bottom line now? >>>>>>>>> >>>>>>>>> should we just treat sisu-guice as "the real brand" of guice? :-) >>>>>>>>> >>>>>>>>> thanks >>>>>>>>> >>>>>>>>> Andrei >>>>>>>>> >>>>>>>>> -- >>>>>>>>> You received this message because you are subscribed to the Google >>>>>>>>> Groups "google-guice" group. >>>>>>>>> To post to this group, send email to [email protected]. >>>>>>>>> To unsubscribe from this group, send email to >>>>>>>>> [email protected]<google-guice%[email protected]> >>>>>>>>> . >>>>>>>>> For more options, visit this group at >>>>>>>>> http://groups.google.com/group/google-guice?hl=en. >>>>>>>>> >>>>>>>>> >>>>>>>> -- >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>> Groups "google-guice" group. >>>>>>>> To post to this group, send email to [email protected]. >>>>>>>> To unsubscribe from this group, send email to >>>>>>>> [email protected]<google-guice%[email protected]> >>>>>>>> . >>>>>>>> For more options, visit this group at >>>>>>>> http://groups.google.com/group/google-guice?hl=en. >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Cheers, Stuart >>>>>>> >>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "google-guice" group. >>>>>>> To post to this group, send email to [email protected]. >>>>>>> To unsubscribe from this group, send email to >>>>>>> [email protected]<google-guice%[email protected]> >>>>>>> . >>>>>>> For more options, visit this group at >>>>>>> http://groups.google.com/group/google-guice?hl=en. >>>>>>> >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "google-guice" group. >>>>>> To post to this group, send email to [email protected]. >>>>>> To unsubscribe from this group, send email to >>>>>> [email protected]<google-guice%[email protected]> >>>>>> . >>>>>> For more options, visit this group at >>>>>> http://groups.google.com/group/google-guice?hl=en. >>>>>> >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "google-guice" group. >>>>> To post to this group, send email to [email protected]. >>>>> To unsubscribe from this group, send email to >>>>> [email protected]<google-guice%[email protected]> >>>>> . >>>>> For more options, visit this group at >>>>> http://groups.google.com/group/google-guice?hl=en. >>>>> >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups >>>> "google-guice" group. >>>> To post to this group, send email to [email protected]. >>>> To unsubscribe from this group, send email to >>>> [email protected]<google-guice%[email protected]> >>>> . >>>> For more options, visit this group at >>>> http://groups.google.com/group/google-guice?hl=en. >>>> >>> >>> >>> >>> -- >>> Cheers, Stuart >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "google-guice" group. >>> To post to this group, send email to [email protected]. >>> To unsubscribe from this group, send email to >>> [email protected]<google-guice%[email protected]> >>> . >>> For more options, visit this group at >>> http://groups.google.com/group/google-guice?hl=en. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "google-guice" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]<google-guice%[email protected]> >> . >> For more options, visit this group at >> http://groups.google.com/group/google-guice?hl=en. >> > > > > -- > Cheers, Stuart > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/google-guice?hl=en. > > -- You received this message because you are subscribed to the Google Groups "google-guice" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-guice?hl=en.
