Patches for fixes are very welcome. These are likely oversights, but won't have any ill-effects because the hashcode methods are never called on the objects (they're never put directly into any hash-based set/map).
sam On Wed, Dec 22, 2010 at 3:09 AM, unguiculus <[email protected]>wrote: > Hello, > > I checked out Guice from trunk and imported the Maven projects into > Eclipse. Eclipse reported four compiler errors, the reason being > missing hashCode implementations. Our Eclipse installations here are > configured to report an error if equals is overriden and hashCode is > not. > > The following classes are affected: > > - DuplicateBindingsTest.SimpleProviderModule > - DuplicateBindingsTest.Foo(){} > - FactoryProvider2<F> > - > MapBinder<K,V>.RealMapBinder<K,V>.RealMapBinderProviderWithDependencies<T> > > Is there a specific reason why these classes only override equals but > not hashCode? The contract for the hashCode method mandates that equal > objects must have equal hash codes. > > I'd suggest that this be fixed. > > Thanks, > Reinhard > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<google-guice%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/google-guice?hl=en. > > -- You received this message because you are subscribed to the Google Groups "google-guice" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-guice?hl=en.
