On 17 Oct 2011, at 00:27, Sam Berlin wrote: > It's just an unfortunate side-effect of the way MOE works. When I sync up > our internal repository with the external one, it first reverts the missing > external changes. Once I get all the changes to the internal repo, MOE will > push them back out. > > Sorry for the confusion. :-(
No worries - glad to hear the fixes will re-appear, was a bit concerned for a moment! > sam > > On Sun, Oct 16, 2011 at 7:15 PM, Stuart McCulloch <[email protected]> wrote: > Hi folks, > > I noticed Sam committed a number of fixes to guice trunk today: > > > ------------------------------------------------------------------------ > r1590 | sberlin | 2011-10-16 17:38:42 +0100 (Sun, 16 Oct 2011) | 1 line > > fix issue 616, thanks for the patch! > > ------------------------------------------------------------------------ > r1589 | sberlin | 2011-10-16 17:29:20 +0100 (Sun, 16 Oct 2011) | 1 line > > fix issue 623, move log4j.properties for persist extension out of src > and into test. > > ------------------------------------------------------------------------ > r1588 | sberlin | 2011-10-16 17:26:00 +0100 (Sun, 16 Oct 2011) | 1 line > > fix issue 624. > > ------------------------------------------------------------------------ > r1587 | sberlin | 2011-10-16 16:55:38 +0100 (Sun, 16 Oct 2011) | 1 line > > Unfortunately all these fixes were then reverted by a "MOE" commit, which > looks as if it was only meant to change one file: > > > ------------------------------------------------------------------------ > r1591 | [email protected] | 2011-10-16 23:34:21 +0100 (Sun, 16 > Oct 2011) | 7 lines > > Fix flaky service test. The whole AsyncService thing probably should > just be rm'd, but fixing the test for now. > > Revision created by MOE tool push_codebase. > MOE_MIGRATION=3475 > > Not sure what process is creating these "MOE" commits, but I don't think it > should be reverting fixes made to the public trunk... > > -- > Cheers, Stuart > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/google-guice?hl=en. > > > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/google-guice?hl=en. -- You received this message because you are subscribed to the Google Groups "google-guice" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-guice?hl=en.
