Got it. Thanks, Stuart. You rock.
I'll push it in from our side.
Christian.
On 20 May 2013, at 2:59, Stuart McCulloch wrote:
FYI, the following patch will fix the maven build:
diff --git a/core/pom.xml b/core/pom.xml
index 283e7e4..43570f2 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -15,6 +15,7 @@
<properties>
<cglib.version>3.0</cglib.version>
+ <asm.version>4.0</asm.version>
</properties>
<dependencies>
@@ -39,6 +40,11 @@
<version>${cglib.version}</version>
</dependency>
<dependency>
+ <groupId>org.ow2.asm</groupId>
+ <artifactId>asm-util</artifactId>
+ <version>${asm.version}</version>
+ </dependency>
+ <dependency>
<groupId>javax.inject</groupId>
<artifactId>javax.inject-tck</artifactId>
<version>1</version>
@@ -207,6 +213,12 @@
<version>${cglib.version}</version>
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>org.ow2.asm</groupId>
+ <artifactId>asm-util</artifactId>
+ <version>${asm.version}</version>
+ <optional>true</optional>
+ </dependency>
</dependencies>
<build>
<plugins>
@@ -215,7 +227,7 @@
<artifactId>jarjar-maven-plugin</artifactId>
<configuration>
<includes>
- <include>*:asm</include>
+ <include>*:asm*</include>
<include>*:cglib</include>
<include>*:guava</include>
<include>*:jsr305</include>
On 19 May 2013, at 06:33, Christian Gruber wrote:
CGLIB was updated to 3.0, and ASM was updated (therefore) to 4.0.
This is working in ant, but if you have the previous versions around,
since some build rules use globs of jars, you have to ensure you
remove all prior versions.
Also (currently) the maven build is not working, but we should have
that fixed up again shortly.
Christian.
On 18 May 2013, at 21:23, Tim Boudreau wrote:
On Sunday, May 19, 2013 12:05:40 AM UTC-4, Tim Boudreau wrote:
In the "be careful what you wish for" department, I could tell you
did
something because my builds started failing :-)
For anyone else with this problem, blowing away Jenkins' checkout
and doing
a fresh checkout cured it - probably some stale
non-version-controlled bits
that the build didn't replace if present.
-Tim
--
You received this message because you are subscribed to the Google
Groups "google-guice" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at
http://groups.google.com/group/google-guice?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Christian Gruber :: Google, Inc. :: Java Core Libraries :: Dependency
Injection
email: [email protected] :::: mobile: +1 (646) 807-9839
--
You received this message because you are subscribed to the Google
Groups "google-guice" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at
http://groups.google.com/group/google-guice?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google
Groups "google-guice" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Christian Gruber :: Google, Inc. :: Java Core Libraries :: Dependency
Injection
email: [email protected] :::: mobile: +1 (646) 807-9839
--
You received this message because you are subscribed to the Google Groups
"google-guice" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
