The former has been on my list to take on, so this particular case, the
patch is well received and appreciated. The first three I feel I can
take on without much of Sam's perspective, but the others I'd rather
take a bit more time and discuss, and that will have to wait for Sam to
return. Let me try to get these build-related changes in, and we can
cut a release-candidate.
cheers,
Christian.
On 9 Jun 2013, at 18:02, Stuart McCulloch wrote:
Thanks, I've been trying out the latest code with some local projects
and so far it's looking good.
I also rebased various patches so they apply cleanly on top of master
- the one I'm most interested in is:
https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_709_externalize_guava_dependency.patch
But I'd also be OK with deferring this and cutting a release asap
rather than cause any further delays.
FYI, other build related patches are:
https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_719_simplify_jarjar_build_setup.patch (depends
on #709)
https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_720_minor_build_improvements.patch
It would also be nice to get some of the following minor patches in,
but they can wait until the next dot release:
https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_288_decouple_thread_local.patch
https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_350_robust_system_get_property.patch
https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_618_extensible_filter_pipeline.patch
https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_695_persistence_properties_provider.patch
https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_723_decouple_anon_type_converters.patch
https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_748_private_modules.patch
--
Cheers, Stuart
On 7 Jun 2013, at 07:09, Christian Gruber wrote:
It's not a pest thing at all. Thank you for giving me the signal.
Let us know if things are problematic (aside from now-fixed build
issues)
Christian.
On 6 Jun 2013, at 23:03, Tim Boudreau wrote:
On Thursday, June 6, 2013 6:57:24 PM UTC-4, Christian Gruber wrote:
I'm really sorry everyone. Trying to keep things moving on several
fronts, I dropped this on the floor. :( I just pushed the fix to
the
maven build. Please have at it. Once I'm done our process should
be
much simpler, easier to keep in sync, and done in small increments.
Woo hoo! All my failing builds are building again! Thanks much,
and sorry
to be a pest about it!
-Tim
--
You received this message because you are subscribed to the Google
Groups "google-guice" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at
http://groups.google.com/group/google-guice?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Christian Gruber :: Google, Inc. :: Java Core Libraries :: Dependency
Injection
email: [email protected] :::: mobile: +1 (646) 807-9839
--
You received this message because you are subscribed to the Google
Groups "google-guice" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at
http://groups.google.com/group/google-guice?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google
Groups "google-guice" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Christian Gruber :: Google, Inc. :: Java Core Libraries :: Dependency
Injection
email: [email protected] :::: mobile: +1 (646) 807-9839
--
You received this message because you are subscribed to the Google Groups
"google-guice" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
