Good feedback. I'll follow up with the CL author. I didn't review that
one.
c.
On 9 Aug 2013, at 19:31, Stuart McCulloch wrote:
Looks good so far... just one question about system property naming:
Commit 605bd086d3ecc4290ddfa4cf89fd840d22d1894c added the following
System.getProperty("guice_include_stack_traces", "DEFAULT")
Previously the only other system property was in BytecodeGen.java
internals:
System.getProperty("guice.custom.loader", "true")
IMHO it would be good to be consistent in the codebase and choose
either dots or underscores as the separator.
On 9 Aug 2013, at 19:47, Christian Gruber wrote:
Hey all,
I just pushed more internal change out to the main open source git
repo. Please build and test it if you're wanting to be on the
bleeding edge - some changes include
More info when encountering duplicates in a multibinder set.
Minor little fixes.
Some rollback churn (sorry)
We have some more things to come, particularly around error handling
and error trace information, but we had to roll it back temporarily
until we figure out some subtleties. But we proceed forward towards a
4.0.
cheers,
Christian.
Christian Gruber :: Google, Inc. :: Java Core Libraries :: Dependency
Injection
email: [email protected] :::: mobile: +1 (646) 807-9839
--
You received this message because you are subscribed to the Google
Groups "google-guice"
group.
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice.
For more options, visit https://groups.google.com/groups/opt_out.
Christian Gruber :: Google, Inc. :: Java Core Libraries :: Dependency
Injection
email: [email protected] :::: mobile: +1 (646) 807-9839
--
You received this message because you are subscribed to the Google Groups
"google-guice" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/google-guice.
For more options, visit https://groups.google.com/groups/opt_out.
