Sounds like a plan to me On 6 Dec 2013, at 23:30, Sam Berlin <[email protected]> wrote:
> OK, great -- so what I propose is this: we (I) fix the CGLIB issues, upgrade > to ASM 4.2, and release a new beta (and hopefully a final release too). > Concurrently, we also put a jar out that's built with ASM5 and offer it as an > experimental version for people who want to use lambdas. > > WDYT? > > sam > > > On Fri, Dec 6, 2013 at 6:27 PM, Stuart McCulloch <[email protected]> wrote: > > On 6 Dec 2013, at 23:11, Sam Berlin <[email protected]> wrote: > >> I want to make sure I understand the state & various options here. AFAICT, >> the relevant issues are: >> >> Issue 757 -- Using Java8 lambdas makes Guice throw terrible error messages >> Issue 759 -- Use ASM4.2 (or, if we want lambda support, 5.0_BETA) >> >> Please correct me where I'm wrong here -- >> >> 1) Switching to ASM4.1 or 4.2 by itself would just be a performance boost, >> but has no other practical gains. Switching to ASM 5.0 would fix make Guice >> work with Java8 lambdas. >> >> 2) Switching to a newer ASM requires a one-line change in CGLIB (as >> described in comment #2 in issue 759). >> >> 3) If we want to drop the asm-util dependency, CGLIB also needs an >> additional patch as described in comment #3 in issue 759. >> >> 4) Both proposed CGLIB patches will work with any of the following: ASM4.1, >> ASM4.2 & ASM5.0. >> >> 5) The only way to get Guice to *work* with Java8 lambdas is to use ASM5.0 >> BETA. If we instead switch to ASM4.1 or ASM4.2, that will improve the error >> message we see, but it won't let lambdas work. > > Yes, that sums up the current situation. > >> Does anyone have an ETA on when ASM5.0 will be non-beta? > > According to http://mail.ow2.org/wws/arc/asm/2013-11/msg00005.html and > http://mail.ow2.org/wws/arc/asm/2013-11/msg00023.html they are targeting > March 2014, and may release a second beta before then. > >> Thanks! >> >> sam > > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/google-guice. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/google-guice. > For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups "google-guice" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/google-guice. For more options, visit https://groups.google.com/groups/opt_out.
